[Webkit-unassigned] [Bug 185045] Enhanced Download Build Product Script with Additional Use Cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 11:11:38 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=185045

Amal Hussein <amal at bocoup.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add Support for a Download  |Enhanced Download Build
                   |Build Product Script        |Product Script with
                   |                            |Additional Use Cases

--- Comment #8 from Amal Hussein <amal at bocoup.com> ---
Change Summary:

1) New Common BuildBinaryFetcher:
- Downloads and extracts minified archives from s3 to WebkitBuild/Release or WebkitBuild/Debug by default
- Downloads and extracts full archives from s3 via optional `full` property
- Downloads either full or minified archive without extracting via optional `no-extract` property
- Downloads and extracts to a specified build directory via optional `build-directory` property
- Constructs the s3 zip url from supplied options if no zip url is passed in
- Fetches the s3 zip directly if an s3 zip url is passed in via the optional `s3_zip_url` property
- Can return a list of sorted revisions for a given set build type
- Prompts a user if a build already exists in the intended extract path
- Skips prompting the user via an optional `delete-first` property

2) Biscet-build:
- gets the sorted revision list from the BuildBinaryFetcher class
- updated to remove all the logic for constructing the s3 zip URL
- removed separate call to extract the archive
- calls the enhanced called the download-build-product with given options and the `delete-first` flag to match existing behavior

3) build-product-archive:
- enhanced to support extracting to a specified build directory via optional `--build-directory` flag

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180515/916bc3be/attachment-0001.html>


More information about the webkit-unassigned mailing list