[Webkit-unassigned] [Bug 184914] Export changes to web-platform-test as part of the webkit-patch upload workflow

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 00:17:53 PDT 2018


--- Comment #15 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 340348
  --> https://bugs.webkit.org/attachment.cgi?id=340348

Some minor comments.
I'll try the workflow later today before r+ing it.

View in context: https://bugs.webkit.org/attachment.cgi?id=340348&action=review

> Tools/Scripts/webkitpy/tool/commands/upload.py:539
> +    help_text = "Opens a pull request to sync any changes in the LayoutTests/imported/w3c/web-platform-tests directory"


> Tools/Scripts/webkitpy/tool/steps/wptchangeexport.py:51
> +        message = 'web-platform-tests changes detected. Would you like to create a pull-request to the WPT github repo now?'

Maybe rephrase to something like: "Would you like to export the changes and/or create a PR to the WPT GitHub repository?:

> Tools/Scripts/webkitpy/w3c/test_exporter.py:125
> +        return self._host.user.prompt_password('Enter github OAuth token: ')

Maybe make it more explicit that the token is for the creation of the PR.

> Tools/Scripts/webkitpy/w3c/test_exporter.py:130
> +        return self._host.user.prompt('Enter github username: ')

s/github/your GitHub/

> Tools/Scripts/webkitpy/w3c/test_exporter.py:250
> +            _log.info('Skipping pull request because OAuth token was not provided. You can open the pull request manually using the branch ' + self.wpt_fork_branch_github_url)

OK, message seems clear to me.

> Tools/Scripts/webkitpy/w3c/test_exporter.py:399
> +    wpt_patch_generator = WebPlatformTestPatchGenerator(host, options)

Might not be worth creating twice the same wpt_patch_generator.
Maybe there is a way to improve this?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180515/41787c62/attachment.html>

More information about the webkit-unassigned mailing list