[Webkit-unassigned] [Bug 185592] [MSE][GStreamer] Before deleting the stream from WebKitMediaSource we should unlink its elements and flush the appsrc.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 14 09:36:35 PDT 2018


--- Comment #12 from Yacine Bandou <bandou.yacine at gmail.com> ---
(In reply to Alicia Boya GarcĂ­a from comment #10)
> Comment on attachment 340280 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=340280&action=review
> > Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:540
> > +            return;
> This is the reason your patch removes the wait for the background thread.
> Flushing an unlinked element is an error, therefore gst_element_send_event()
> returns != 0 and the function returns here, not reaching
> `gst_element_set_state(stream->appsrc, GST_STATE_NULL);` which is a few
> lines below.
> With the patch the pipeline state is not changed to NULL, therefore the
> streaming thread is not finished -- and incidentally, no wait for its
> termination occurs.

I agree, that's exactly what's happening.
It is not a good solution ;)

I'll try to see how to fix this block, if you have any suggestions don't hesitate

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180514/effa8726/attachment.html>

More information about the webkit-unassigned mailing list