[Webkit-unassigned] [Bug 184914] Export changes to web-platform-test as part of the webkit-patch upload workflow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184914

--- Comment #10 from Brendan McLoughlin <brendan at bocoup.com> ---

> I wonder whether we should provide the possibility to just create a remote branch but not create the PR right away.
> The main advantage I see is that in that case, you do not have to provide the OAuth token.
> Maybe, if the OAuth token is not provided, we could still create the remote branch?

Sounds like a good idea. I'll try it out.

> Can we add a FIXME to use the keychain?

Will do.

> Would it make sense to set the default value to true, or to add a no-interactive mode?

I was originally trying to avoid changing the existing behavior but a no-interactive seems like a better option.


> This is only style but we usually do early return.

I'll update this to use the early return.


> Maybe silent_noop should be inverted to be something like log_if_nowptchange.
I like the log_if_nowptchange suggestion. I'll make that change too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180514/1be972fc/attachment.html>