[Webkit-unassigned] [Bug 185592] [MSE][GStreamer] Before deleting the stream from WebKitMediaSource we should unlink its elements and flush the appsrc.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 14 05:48:44 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=185592

--- Comment #8 from Yacine Bandou <bandou.yacine at gmail.com> ---
(In reply to Alicia Boya García from comment #7)
> (In reply to Yacine Bandou from comment #5)
> > (In reply to Alicia Boya García from comment #4)
> > > (In reply to Yacine Bandou from comment #0)
> > > > Before delete the stream from WebKitMediaSource we need to unlink the
> > > > elements appsrc and parser and flush 
> > > > the appsrc before setting its state to NULL, otherwise we'll block in appsrc
> > > > when we go from paused state to ready.
> > > 
> > > Is the problem you are mentioning a deadlock or just an avoidable wait?
> > 
> > I think it is just an avoidable wait in "gst_pad_stop_task" of basesrc
> > (appsrc).
> 
> So, have you noticed any measurable improvement with the patch?

When we properly unlink and flush the appsrc (basesrc), we don't stay block when we go from the paused state to ready in appsrc.

Do you have an other way to avoid this blocking ? I attached the thread call stack

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180514/5e62f968/attachment.html>


More information about the webkit-unassigned mailing list