[Webkit-unassigned] [Bug 185555] New: -Wmemset-elt-size warning in LibWebRTCSocket constructor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 11 11:33:37 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=185555

            Bug ID: 185555
           Summary: -Wmemset-elt-size warning in LibWebRTCSocket
                    constructor
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: alex at igalia.com, youennf at gmail.com

GCC is getting smarter. This looks bad:

../../Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp:57:44: warning: ‘memset’ used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
     memset(&m_options, 1, MAX_SOCKET_OPTION);
                                            ^

I assume the intent of the code was to set all of m_options to 1, but it's only setting the first quarter of m_options (assuming the usual sizeof(int) == 4), right?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180511/020e4401/attachment.html>


More information about the webkit-unassigned mailing list