[Webkit-unassigned] [Bug 185535] [EME][GStreamer] Handle the protection event in MediaPlayerPrivate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185535

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340149|review?, commit-queue?      |review+, commit-queue+
              Flags|                            |

--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 340149
  --> https://bugs.webkit.org/attachment.cgi?id=340149
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340149&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1217
> +    if (m_cdmInstance && strcmp(GStreamerEMEUtilities::keySystemToUuid(m_cdmInstance->keySystem()), eventKeySystemUUID))

Better to use g_strcmp0.
It would be interesting to add a GST_TRACE or DEBUG comment for the bail out here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180511/614083b0/attachment-0001.html>