[Webkit-unassigned] [Bug 184914] Export changes to web-platform-test as part of the webkit-patch upload workflow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184914

--- Comment #6 from youenn fablet <youennf at gmail.com> ---
> > Tools/Scripts/webkitpy/w3c/test_exporter.py:67
> > +        git_commit = "HEAD...." if not self._options.git_commit else self._options.git_commit + "~1.." + self._options.git_commit
> > +        patch_data = self._host.scm().create_patch(git_commit, [WEBKIT_WPT_DIR])
> 
> This assumes scm is a git. This is simply not true for many WebKit
> contributors.
> r- because of this. Use scm.create_patch instead.

This code is already using scm.create_patch so it should work with SVN (although I never tested it).

> > Tools/Scripts/webkitpy/w3c/test_exporter.py:142
> > +            self._username = self._git.local_config('github.username').rstrip()
> 
> Please use
> https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/
> net/credentials.py
> and read username/password from KeyChain as well.

That would indeed be good to do.
That said, I would separate the integration refactoring from adding additional support like reading from KeyChain.
Seems fine to do those in parallel.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180510/e6ff1114/attachment.html>