[Webkit-unassigned] [Bug 185492] Support --verbose in run-javascriptcore-tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185492

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dbates at webkit.org
 Attachment #340033|review?                     |review+
              Flags|                            |

--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 340033
  --> https://bugs.webkit.org/attachment.cgi?id=340033
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340033&action=review

> Tools/Scripts/run-javascriptcore-tests:235
> +  --verbose:                    Print more things while running. (can be specified multiple times)

Looking at the existing usage descriptions in this file and in test-webkitpy we seem to incorporate the parentheses into the first sentence instead of in another sentence, taking inspiration from test-webkitpy I would write this as:

Verbose output (specify more than once to increase verbosity).

> Tools/Scripts/run-javascriptcore-tests:524
> +        push(@jscStressDriverCmd, ("--verbose") x $verbose)

Missing ‘;’ at the end of this line. Not sure how this ran without an error/warning. We prefer to write single body if blocks using one line:

push(@jscStressDriverCmd, ("--verbose") x $verbose) if ($verbose > 0);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180510/da511cf6/attachment.html>