[Webkit-unassigned] [Bug 185495] New: ArraySpeciesCreate not checking for max length on array like objects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 9 16:11:19 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=185495

            Bug ID: 185495
           Summary: ArraySpeciesCreate not checking for max length on
                    array like objects
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: leonardo.balter at gmail.com
                CC: utatane.tea at gmail.com

I got a false positive from the test runner while working on Bug 185476. While the fix there is still fine, it doesn't solve the whole problem where a RangeError is not observed for non-array objects with the length property set to values > 2**32-1. 

`constructArrayWithSizeQuirk` in the Source/JavaScriptCore/runtime/ArrayConstructor.cpp file has a check for the length - code below - but I was unable to reach it. My first patch was calling it but it's still not successful.

```
    uint32_t n = length.toUInt32(exec);
    if (n != length.toNumber(exec))
        return throwException(exec, scope, createRangeError(exec, ASCIILiteral("Array size is not a small enough positive integer.")));
```

Yusuke, would you help me here, please?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180509/5d4c5ebb/attachment.html>


More information about the webkit-unassigned mailing list