[Webkit-unassigned] [Bug 176615] AX: VoiceOver iframe scrolling focus jumping bug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176615

--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 339895
  --> https://bugs.webkit.org/attachment.cgi?id=339895
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339895&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:3027
>      IntRect newSubfocus = subfocus;
>      IntRect newElementRect = snappedIntRect(elementRect());
> -    IntRect scrollParentRect = snappedIntRect(scrollParent->elementRect());
>      newSubfocus.move(newElementRect.x(), newElementRect.y());
> -    newSubfocus.move(-scrollParentRect.x(), -scrollParentRect.y());
>      

We have a family of helper functions for this kind of thing: Widget::convertToContainingView, convertToRootView etc. Please always use those rather than trying to hand-roll coordinate conversion code, since they know about things like scroll view insets and headers/footers.

> Source/WebCore/accessibility/AccessibilityObject.cpp:3028
>      // Recursively make sure the scroll parent itself is visible.

Why isn't this just using RenderLayer::scrollRectToVisible() which knows how to do all this scrolling?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180509/089cba07/attachment.html>