[Webkit-unassigned] [Bug 185245] [EME][GStreamer] Add a handler for GStreamer protection event

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 8 04:44:47 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=185245

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339713|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 339713
  --> https://bugs.webkit.org/attachment.cgi?id=339713
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339713&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:-1270
> -    ASSERT_NOT_REACHED();

Please, leave this outside the patch. If you need this out of here, create a new bug and set a dependency to this one.

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:1093
> +    GST_DEBUG("Handling event %s on appendPipeline appsinkPad", GST_EVENT_TYPE_NAME(event));

appendPipeline -> append pipeline

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180508/d94e9dfb/attachment.html>


More information about the webkit-unassigned mailing list