[Webkit-unassigned] [Bug 185194] [GTK] Error building WebKitGtk+ with gcc version 7.3.1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185194

--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
I'm having a *lot* of trouble with this. JF, is it OK if I rollout r231170 for now? I think we need to; unfortunately, I don't see a path right now to using --std=c++17 with GCC 7.

GCC 6 and GCC 8 don't seem to have any such problems. GCC 6 is good because it doesn't support std::optional yet; that's why all the bots are green. And I guess GCC 8 has a smarter std::optional.

--std=c++17 is still experimental, even in GCC 8. I think we still gained a lot from requiring GCC 6, even if we backtrack on making the transition to C++ 17 so early on.

(In reply to Miguel Gomez from comment #4)
> After some tests here and there, I decided to upgrade my Fedora in case it
> was a bug in gcc or the std lib. I upgraded to Fedora 27, which has gcc
> version 7.3.1 20180303 (Red Hat 7.3.1-5) and with after that I'm able to
> build without errors.

Are you sure you kept the WebKit revision the same? Because Yusuke's patch to use system std::optional got reverted for a little while. My guess is you tested Fedora 27's GCC using a revision where it had been reverted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180508/819f3194/attachment.html>