[Webkit-unassigned] [Bug 184584] [MIPS] Optimize generated JIT code using mips32r2 instructions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184584

Yusuke Suzuki <utatane.tea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339717|review?                     |review+
              Flags|                            |

--- Comment #10 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 339717
  --> https://bugs.webkit.org/attachment.cgi?id=339717
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339717&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:323
> +    void loadAddress(BaseIndex address, bool loadTrail = true)

Use `enum class` instead of `bool`. In this case, not using default parameter is better.
And `loadTrail` is a bit confusing. Maybe, `enum class LoadAddressMode { DontAddOffset, AddOffset };` would be more descriptive.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180508/4df1ab4a/attachment-0001.html>