[Webkit-unassigned] [Bug 185387] There are so many ways to do the same thing in VersionNameMap

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185387

--- Comment #1 from Jonathan Bedard <jbedard at apple.com> ---
Some of these invocations are only exist because Python doesn't allow a constructor to be hidden. It is always the case, especially for Apple's ports, that the VersionNameMap.map(...) function should be used, specifically because of apple_additions.

In some of the other cases, you're explicitly overriding the default PlatformInfo  object. Given the fact that you shouldn't be using the default constructor, we can definitely eliminate 1 and 2.  There is also an argument to be made that we shouldn't define a default PlatformInfo object if the user does not provide us with one.  That would eliminate 5 and 6.

However, we definitely need to keep the ability to override the default platform in to_name.  As mentioned in <https://bugs.webkit.org/show_bug.cgi?id=185386>, we rely on this in iOS where we don't have an iOS PlatformInfo object when we need to extract version information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180507/78bbb2c0/attachment.html>