[Webkit-unassigned] [Bug 185387] New: There are so many ways to do the same thing in VersionNameMap

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185387

            Bug ID: 185387
           Summary: There are so many ways to do the same thing in
                    VersionNameMap
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: dbates at webkit.org
                CC: jbedard at apple.com, lforschler at apple.com

>From my understanding the purpose of VersionNameMap is to map an OS version number to a human readable name (e.g. High Sierra) and vice-versa. Looking at operations to map a version number to a name I count at least 8 ways to do this:

Let P be a PlatformInfo object.

VersionNameMap().to_name(...)
VersionNameMap().to_name(..., platform="...")
VersionNameMap(P).to_name(...)
VersionNameMap(P).to_name(..., platform="...")
VersionNameMap.map().to_name(...)
VersionNameMap.map().to_name(..., platform="...")
VersionNameMap.map(P).to_name(...)
VersionNameMap.map(P).to_name(..., platform="...")

And quickly glancing through the code these invocation may give different results regardless of whether both P and platform="..." are in agreement depending on the presence of Apple Additions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180507/b27ad6ee/attachment.html>