[Webkit-unassigned] [Bug 185386] New: Using VersionNameMap is confusing; two different concepts are called "platform"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185386

            Bug ID: 185386
           Summary: Using VersionNameMap is confusing; two different
                    concepts are called "platform"
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: dbates at webkit.org
                CC: jbedard at apple.com, lforschler at apple.com,
                    rniwa at webkit.org

VersionNameMap is confusing to use. One of the issues is that various VersionNameMap functions, including the constructor, take a "platform" that could either be a string that represents the OS name (e.g. High Sierra) or a PlatformInfo object. You need to read the code of each function to know what data type the function argument named "platform" should be.

Expect a PlatformInfo object to be passed for "platform":

VersionNameMap.__init__()
VersionNameMap.map()

Expect a string for "platform":

VersionNameMap.to_name()
VersionNameMap.names()
VersionNameMap.mapping_for_platform()

On another note, it seems weird that VersionNameMap is instantiated with a PlatformInfo for the purpose of querying the platform for the OS name and its member functions can also take an OS name to override the OS name computed in the constructor.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180507/80f32747/attachment-0001.html>