[Webkit-unassigned] [Bug 185370] WKPageSetMediaVolume() API couldn't be used to restore the volume

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185370

--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
(In reply to Xabier Rodríguez Calvar from comment #4)
> (In reply to Vivek Arumugam from comment #3)
> > 2) And if we are to pass some value, again, we can't be passing any absolute
> > value from UI Process because at that moment the media players (from
> > different documents) from the same page might have different volumes. This
> > argument supports the use of factored/multiplier approach as
> > WKPageSetMediaVolume().
> 
> This value would reduce the volume as it is done for WKPageSetMediaVolume
> but it would be recoverable after with UnDimm.
> 
> > If we are worried about breaking existing functionality of
> > WKPageSetMediaVolume(), we should first confirm that the purpose of
> > WKPageSetMediaVolume() is different than what I think it is.
> 
> We need to consider this, yes. If a set is made while the volume is dimmed,
> we need to deal with it somehow, either by failing or ignoring the set or by
> failing/ignoring the undimm.

I would prefer to fix the existing API if possible instead of introducing a new one. The proposed change will not break any usage I am aware of.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180507/6d44787c/attachment.html>