[Webkit-unassigned] [Bug 185244] [EME][GStreamer] Crash when the mediaKeys are created before loading the media in debug conf

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 7 02:42:07 PDT 2018


--- Comment #11 from Yacine Bandou <bandou.yacine at gmail.com> ---
(In reply to Xabier Rodríguez Calvar from comment #10)
> (In reply to Yacine Bandou from comment #9)
> > I added it because I had a crash in some test.
> > Otherwise, If we remove the assert from attach, I don't see the
> > inconvenience of removing it from dettach.
> It had the same idea but different consequences. In the case of attach, we
> do get it called multiple times and nothing happens if it is the same CDM
> instance. Actually, we might want to add an assert to check if we are
> assigned a different instance.
> In the case of detach, we should still assert because we are getting a
> request to detach an instance we don't know.

With the assert in the cdmInstanceDetached function the following test "imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-different-mediakeys.https.html" crashes.

Without the assert the test passes.

We have two solutions, we remove the Assert or we leave it but we will note that the test will be crashed in TestExpectations.

What do you suggest?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180507/3d296713/attachment.html>

More information about the webkit-unassigned mailing list