[Webkit-unassigned] [Bug 185245] [EME][GStreamer] Add a handler for GStreamer protection event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185245

--- Comment #5 from Yacine Bandou <bandou.yacine at gmail.com> ---
(In reply to Xabier Rodríguez Calvar from comment #4)
> Comment on attachment 339550 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=339550&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1288
> > +    const gchar* eventKeySystemId = nullptr;
> > +    GstBuffer* data = nullptr;

> > +        GST_DEBUG("scheduling OnEncrypted event for %s with concatenated init datas size of %" G_GSIZE_FORMAT, eventKeySystemId, initData.size());
> > +        GST_MEMDUMP("init datas", initData.data(), initData.size());
> > +        this->m_player->initializationDataEncountered(ASCIILiteral("cenc"), ArrayBuffer::create(initData.data(), initData.size()));
> > +    });
> 
> This is a nice piece of code though it should belong in other patch.

I agree, I'll do it

> 
> You will need to get rid of some variables that are not needed anymore. I'd
> recommend you base your code in
> https://github.com/WebPlatformForEmbedded/WPEWebKit/blob/wpe-20170728/Source/
> WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.
> cpp#L1441 and since that code is mine, authorship should be at least shared
> with me. We'll find somebody else to do the formal r+.
> 
> So summing up, please move this out of this patch and since this patch
> should depend on that new one, add the dependency.
> 
> > Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:1100
> > +        if (appendPipeline && appendPipeline->playerPrivate())
> > +            appendPipeline->playerPrivate()->handleProtectionEvent(event);
> > +        break;
> 
> I think it is better to return GST_PAD_PROBE_DROP since the protection event
> should die here and be moved to the PlaybackPipeline.

Ok it's noted.
I hesitated to put GST_PAD_PROBE_OK or GST_PAD_PROBE_DROP for the protection event.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180507/67dcd611/attachment.html>