[Webkit-unassigned] [Bug 185244] [EME][GStreamer] Crash when the mediaKeys are created before loading the media in debug conf
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 7 01:45:39 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=185244
--- Comment #9 from Yacine Bandou <bandou.yacine at gmail.com> ---
(In reply to Xabier RodrÃguez Calvar from comment #7)
> Comment on attachment 339501 [details]
> Patch
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=339501&action=review
>
> > Source/WebCore/ChangeLog:11
> > + to the MediaPlayerPrivate via "MediaPlayerPrivateGStreamerBase::cdmInstanceAttached" before laoding
>
> loading
>
> >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1222
> >> + if (m_cdmInstance.get() == &instance) {
> >
> > .get() required here?
>
> It looks like it is not. Besides, I don't think this chunk of code is
> necessary as detach is not called multiple times as attach is. Unless you
> think I am wrong, please remove this chunk and leave the code as it was.
I added it because I had a crash in some test.
Otherwise, If we remove the assert from attach, I don't see the inconvenience of removing it from dettach.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180507/79adfd5e/attachment.html>
More information about the webkit-unassigned
mailing list