[Webkit-unassigned] [Bug 185278] Remove dead exception in MediaList.appendMedium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 4 09:39:03 PDT 2018


--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Darin Adler from comment #4) 
> I don’t think this is a backwards compatible change for the GTK port.
> Instead we should keep the error argument for now even if *error is never
> going to be set to something non-null. One of the maintainers of the GTK
> port should weigh in on this.

Yes, that's exactly right. That's public API that must not be changed. Thanks for noticing this, Darin!

Chris, you can just keep the error parameter, restore the g_return_if_fail(!error || !*error), and then do nothing else with it. It's fine to have an error parameter for legacy reasons, even if it will no longer be set.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180504/ad845866/attachment.html>

More information about the webkit-unassigned mailing list