[Webkit-unassigned] [Bug 185253] [WPE] Fix build for ENABLE_TOUCH_EVENTS=OFF

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 3 18:27:44 PDT 2018


--- Comment #13 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to Michael Catanzaro from comment #12)
> (In reply to Michael Catanzaro from comment #11)
> > (That said, I don't have a strong opinion about this; if Zan wants
> > ENABLE_TOUCH_EVENTS to be PUBLIC, then that's fine with me.)
> Basically the tradeoffs I see to exposing it are:
> * Benefits: none(?)
> * Cost: one more configuration that can (and, obviously, will) often fail to
> build

I have never argued to make this option public.

There is currently a build option (which is private), and building with it its broken. And here is a more than reasonable patch to fix that breakage.

I don't know why you are mixing one thing with the other.

If we aren't even going to accept patches for fixing the breakage for changing the value of private options, why having this private options at all?  What is the point? 

Why we don't convert all private options to unconditional definitions that can't be changed of value?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180504/5ec8ca10/attachment.html>

More information about the webkit-unassigned mailing list