[Webkit-unassigned] [Bug 185269] Range bisector should check the commits for repositories without change in specified range.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 3 16:11:22 PDT 2018


--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 339472
  --> https://bugs.webkit.org/attachment.cgi?id=339472

View in context: https://bugs.webkit.org/attachment.cgi?id=339472&action=review

> Websites/perf.webkit.org/ChangeLog:8
> +        For the repositories those do not have change in specified range, we still need to use them

This is kind of wordy. How about "For repositories without a change in the specified range,

> Websites/perf.webkit.org/ChangeLog:9
> +        to filter commit sets.

You need to explain why we need to do that. In a way, what you've stated so far is "what".
We need "why".

> Websites/perf.webkit.org/public/v3/commit-set-range-bisector.js:19
> +        const topLevelRepositoriesWithCommitHasOrdering = firstCommitSet.topLevelRepositories()

This phrase isn't grammatically correct. topLevelRepositoriesWithOrderedCommits?

> Websites/perf.webkit.org/unit-tests/commit-set-range-bisector-tests.js:666
> +        it('should use still check the repository revision even the repository has no change in the range', async () => {

should still check or should still use? Can't have two verbs.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180503/081dbb01/attachment.html>

More information about the webkit-unassigned mailing list