[Webkit-unassigned] [Bug 185253] [WPE] Fix build for ENABLE_TOUCH_EVENTS=OFF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185253

--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Carlos Alberto Lopez Perez from comment #9)
> Following your reasoning we should remove all the private cmake config
> options. I don't buy that, neither I think is a good idea.

There's no point in having option visibility at all if we ignore the rules. It's simply not practical to expect that arbitrary ports build with arbitrary configurations of the 100+ private options defined in WebKitFeatures.cmake.

It's definitely wrong for meta-webkit to expose PRIVATE options. If the options are interesting to expose, they should almost surely be made PUBLIC. (Again, this should be approved by Zan.) Otherwise, they should be removed from meta-webkit.

If you want to support disabling ENABLE_TOUCH_EVENTS for WPE, you should make it PUBLIC. Otherwise, it's IMO wrong to add ENABLE_TOUCH_EVENT conditions in WPE-specific files. In the past, we've actively removed such conditions after discovering that the option is PRIVATE. Having such conditions creates the false impression that both codepaths are supported.

Exposing options should be done with care; we have way too many with GTK, and don't want to repeat that mistake for WPE. Previously, for WPE we've often taken the approach that options should be PRIVATE unless making them PUBLIC allows disabling a dependency (e.g. ENABLE_XSLT). In contrast, it's not clear why you would ever want to disable touch event support. Don't say "because the target device has no touchscreen," because disabling ENABLE_TOUCH_EVENTS doesn't avoid any dependency, and there's hardly any code supporting it, so the impact on binary size is probably unnoticeable, so there's probably no good motivation to disable it even if touch events will never be generated. There should be a good reason to expose such options. (That said, I don't have a strong opinion about this; if Zan wants ENABLE_TOUCH_EVENTS to be PUBLIC, then that's fine with me.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180503/d18b9dac/attachment-0001.html>