[Webkit-unassigned] [Bug 182689] Unified builds broke ycm autocompletion using compilation databases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182689

--- Comment #14 from Carlos Eduardo Ramalho <cadubentzen at gmail.com> ---
(In reply to Sergio Villar Senin from comment #13)
> BTW have you measured how this affects build times? We're adding additional
> writes so there might be some impact...

The files are written during project generation (cmake command). I measured in my machine the time to execute 'build-webkit --release --gtk --generate-project-only' five times after a clean-up:

- Before the patch:

7,15s user 1,75s system 72% cpu 12,271 total
7,27s user 2,00s system 74% cpu 12,458 total
7,36s user 1,85s system 73% cpu 12,504 total
7,38s user 1,93s system 74% cpu 12,559 total
7,25s user 1,82s system 73% cpu 12,363 total
--------------------------------------------
Average:
7,28s user 1,87s system 73% cpu 12,431 total

- After the patch:

7,20s user 1,86s system 72% cpu 12,444 total
7,49s user 1,84s system 74% cpu 12,550 total
7,46s user 1,97s system 74% cpu 12,712 total
7,24s user 1,92s system 73% cpu 12,427 total
7,55s user 1,88s system 73% cpu 12,761 total
--------------------------------------------
Average:
7,38s user 1,89s system 73% cpu 12,579 total


The impact seems minimal. In case it isn't desirable to have those files written in every cmake build, we could make an option and enable it only when building with the 'build-webkit' script.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180503/5528e1a3/attachment.html>