[Webkit-unassigned] [Bug 185253] [WPE] Fix build for ENABLE_TOUCH_EVENTS=OFF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185253

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339408|commit-queue?               |commit-queue-
              Flags|                            |

--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 339408
  --> https://bugs.webkit.org/attachment.cgi?id=339408
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339408&action=review

> Source/WebKit/ChangeLog:6
> +        This commit is a port of r190987 committed for GTK platform

This should come below the review by line.

> Source/WebKit/ChangeLog:7
> +        (http://trac.webkit.org/changeset/190987) to WPE

Missing period at the end.

> Source/WebKit/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).

This should be above the commit message.

> Source/WebKit/UIProcess/API/wpe/WPEView.cpp:34
> +#if ENABLE(TOUCH_EVENTS)

Should be moved below other includes:
#include <wpe/wpe.h>

#if ENABLE(TOUCH_EVENTS)
#include "NativeWebTouchEvent.h"
#endif

> Tools/ChangeLog:6
> +        This commit is a port of r190987 committed for GTK platform

Same comments as for other changelog.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180503/0bde553a/attachment.html>