[Webkit-unassigned] [Bug 185222] Create analysis task should sync analysis task status after creation.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 20:42:49 PDT 2018


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #339359|review?                     |review+
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 339359
  --> https://bugs.webkit.org/attachment.cgi?id=339359

View in context: https://bugs.webkit.org/attachment.cgi?id=339359&action=review

> Websites/perf.webkit.org/unit-tests/analysis-task-tests.js:327
> +        it('should sync the new analysis task status onceit is created', async () => {

Nit: Need a space between "once" and "it".

> Websites/perf.webkit.org/unit-tests/analysis-task-tests.js:386
> +        });

Please add another test where the creation of an analysis fails and a rejected promise is returned (as opposed to throwing an exception).

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180503/de17c3e4/attachment.html>

More information about the webkit-unassigned mailing list