[Webkit-unassigned] [Bug 185205] Can't copy and paste URLs that have no title into Mail (macOS)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185205

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339344|review?                     |review+
              Flags|                            |

--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 339344
  --> https://bugs.webkit.org/attachment.cgi?id=339344
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339344&action=review

> Source/WebCore/platform/mac/PasteboardMac.mm:202
> -        paths.append(pasteboardURL.title.stripWhiteSpace());
> +        paths.append([title stringByTrimmingCharactersInSet:[NSCharacterSet whitespaceCharacterSet]]);

We should probably just use our stripWhiteSpace, not Cocoa’s. You’re going to turn it into a String soon anyway, might as well do it before that step and use more WebKit code.

> Tools/TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:116
> +    urls = [WebURLsWithTitles URLsFromPasteboard: [NSPasteboard generalPasteboard]];

No spaces after colons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180502/bbc99aee/attachment-0001.html>