[Webkit-unassigned] [Bug 185215] New: The generateConditionsForPropertyBlah API should have a nicer handling of custom accessors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185215

            Bug ID: 185215
           Summary: The generateConditionsForPropertyBlah API should have
                    a nicer handling of custom accessors
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fpizlo at apple.com

This code smells funny:

if (!slot.isCacheableCustom()) {
    conditionSet = generateConditionsForPrototypePropertyHit(
        vm, codeBlock, exec, structure, slot.slotBase(),
        propertyName.impl());
} else {
    conditionSet = generateConditionsForPrototypePropertyHitCustom(
        vm, codeBlock, exec, structure, slot.slotBase(),
        propertyName.impl());
}

Maybe the `if` should be inside generateConditionsForPrototypePropertyHit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180502/711aa5aa/attachment.html>