[Webkit-unassigned] [Bug 184166] Xcode prepends line comments from WTF/Compiler.h to *.sb files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 29 20:50:26 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=184166

--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
(In reply to Alexey Proskuryakov from comment #1)
> The fix would be two-fold:
> 
> 1. Add a script step to remove comment lines from processed profiles.
> 2. Change preprocessor mode to C++.

Looks like both parts might be doable all in one step here:
https://github.com/WebKit/webkit/blob/master/Source/WebKit/DerivedSources.make#L220-L227

I wonder if it's safe to replace all of the above with the following?
> TEXT_PREPROCESSOR_FLAGS=-E -P -x -w

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180330/58daa000/attachment.html>


More information about the webkit-unassigned mailing list