[Webkit-unassigned] [Bug 184166] New: Xcode prepends line comments from WTF/Compiler.h to *.sb files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184166

            Bug ID: 184166
           Summary: Xcode prepends line comments from WTF/Compiler.h to
                    *.sb files
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ross.kirsling at sony.com

Repro:

1. Add a line comment (// not /* */) to the start of a line in this file: https://github.com/WebKit/webkit/blob/master/Source/WTF/wtf/Compiler.h
2. Open Xcode and hit the Play button
=> WebContent process crashes immediately

Cause:

The comment gets prepended to this file, in which C-style comments are invalid:
/Users/.../Library/Developer/Xcode/DerivedData/WebKit-.../Build/Products/Debug/WebKit.framework/Resources/com.apple.WebProcess.sb
(It will also be prepended to com.apple.WebKit.NetworkProcess.sb and com.apple.WebKit.Storage.sb in the same directory.)

This file originates here:
https://github.com/WebKit/webkit/blob/master/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
It appears to be processed by this script:
https://github.com/WebKit/webkit/blob/master/Source/WebKit/DerivedSources.make


Reason for concern:

This issue is very time-consuming to debug for the following reasons.
- It is completely unexpected, as C, C++, and ObjC all support line comments.
- The issue only occurs from the Xcode UI and not from the `build-webkit` CLI.
- Selecting Product > Clean in Xcode is not a fix -- one must actually delete the DerivedData subdirectory (the existence of which is hardly common knowledge!).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180330/cac22cb6/attachment.html>