[Webkit-unassigned] [Bug 183740] [MIPS] Optimize JIT code generated by methods with TrustedImm32 operand

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183740

--- Comment #7 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 336278
  --> https://bugs.webkit.org/attachment.cgi?id=336278
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336278&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2476
> +        ASSERT(0);

Use ASSERT_NOT_REACHED();

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2578
> +            }

Why don't we check m_fixedWidth?

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2612
>      void test8(ResultCondition cond, Address address, TrustedImm32 mask, RegisterID dest)

Please use mask8OnTest on test8.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180329/a9f9e29c/attachment.html>