[Webkit-unassigned] [Bug 184039] webkitpy: Implement coredumpctl support on linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184039

--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 336766
  --> https://bugs.webkit.org/attachment.cgi?id=336766
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336766&action=review

FWIW, I can't think of a better way to check for the backtrace than this sleep loop. It's not like we can poll a filesystem location or hook into some form of notifications or anything, so the sleep loop looks OK to me.

So this looks good to me. And I believe Carlos Lopez was also OK with it, right?

> Tools/Scripts/webkitpy/port/linux_get_crash_log.py:63
> +        for try_number in xrange(5):

Use range() so that it works with python3

Um, I see Daniel asked you to not do that, but reality is going to catch up with us pretty soon here, so my vote is definitely for range().

> Tools/Scripts/webkitpy/port/linux_get_crash_log.py:65
> +                # Loopping, it means we consider the logs might not be ready yet.

Looping

> Tools/Scripts/webkitpy/port/linux_get_crash_log.py:71
> +            except ScriptError:

What happens if coredumpctl is not installed? Are you sure it only throws ScriptError? I think it can throw an OSError. Check by changing 'coredumpctl' to gibberish.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180329/9ceffebb/attachment.html>