[Webkit-unassigned] [Bug 184127] New: [CMake] WebKit should link to WebCore as a PRIVATE library

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184127

            Bug ID: 184127
           Summary: [CMake] WebKit should link to WebCore as a PRIVATE
                    library
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: Hironori.Fujii at sony.com
            Blocks: 174003

[CMake] WebKit should link to WebCore as a PRIVATE library

While trying to build TestWebKit for Windows port (Bug 174003), I see the following linkage error.

> ------ Build started: Project: TestWebKitLib, Configuration: Debug x64 ------
> WebCore.lib(UnifiedSource311.obj) : error LNK2005: "struct WTFLogChannel * __cdecl WebCore::notImplementedLoggingChannel(void)" (?notImplementedLoggingChannel at WebCore@@YAPEAUWTFLogChannel@@XZ) already defined in WebKit2.lib(WebKit2.dll)
>    Creating library C:/webkit/gb/WebKitBuild/Debug/lib64/TestWebKitLib.lib and object C:/webkit/gb/WebKitBuild/Debug/lib64/TestWebKitLib.exp
> C:\webkit\gb\WebKitBuild\Debug\bin64\TestWebKitLib.dll : fatal error LNK1169: one or more multiply defined symbols found
> Done building project "TestWebKitLib.vcxproj" -- FAILED.
> ========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

This happens because TestWebKitLib links to both WebCore and WebKit.
But, TestWebKitLib explicitly links only with WebKit,
WebCore is propagated because WebKit links WebCore as PUBLIC.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=174003
[Bug 174003] [WinCairo] Implement WebKit for WinCairo
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180329/ba334bc9/attachment.html>