[Webkit-unassigned] [Bug 184037] [WPE] Floating point exception in WebEventFactory::createWebWheelEvent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 28 17:09:57 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=184037

--- Comment #4 from Carlos Eduardo Ramalho <cadubentzen at gmail.com> ---
Comment on attachment 336583
  --> https://bugs.webkit.org/attachment.cgi?id=336583
Patch

>Subversion Revision: 229973
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 6b224d55338fbfcc0f7299a83aa63d06a640291a..b5539ff8f658ba0f5344d4b619ddd953f9f28280 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-03-27  Carlos Eduardo Ramalho  <cadubentzen at gmail.com>
>+
>+        [WPE] Floating point exception in WebEventFactory::createWebWheelEvent
>+        https://bugs.webkit.org/show_bug.cgi?id=184037
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/wpe/WebEventFactory.cpp:
>+        (WebKit::WebEventFactory::createWebWheelEvent):
>+
> 2018-03-25  Carlos Garcia Campos  <cgarcia at igalia.com>
> 
>         [GTK][WPE] Add API to convert between DOM and JSCValue
>diff --git a/Source/WebKit/Shared/wpe/WebEventFactory.cpp b/Source/WebKit/Shared/wpe/WebEventFactory.cpp
>index 6bedf6a465552951a4b63a4f0c41a6c25011e6dc..626829f6ac158e3f6dca941c4f1d2f73053a5b00 100644
>--- a/Source/WebKit/Shared/wpe/WebEventFactory.cpp
>+++ b/Source/WebKit/Shared/wpe/WebEventFactory.cpp
>@@ -134,6 +134,9 @@ WebMouseEvent WebEventFactory::createWebMouseEvent(struct wpe_input_pointer_even
> 
> WebWheelEvent WebEventFactory::createWebWheelEvent(struct wpe_input_axis_event* event, float deviceScaleFactor)
> {
>+    if (!event->value)
>+        return { };
>+
>     // FIXME: We shouldn't hard-code this.
>     enum Axis {
>         Vertical,

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180329/e9730384/attachment-0001.html>


More information about the webkit-unassigned mailing list