[Webkit-unassigned] [Bug 184062] New: MSVC __forceinline slows down JSC release build fivefold after r229391

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=184062

            Bug ID: 184062
           Summary: MSVC __forceinline slows down JSC release build
                    fivefold after r229391
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ross.kirsling at sony.com

After the TMP refactor in r229391 (https://bugs.webkit.org/show_bug.cgi?id=183263), the WinCairo Release build takes 50 minutes to compile JSC alone, compared to only 10 minutes prior to the patch.

This is an MSVC-specific issue -- their optimizer has trouble dealing with "too liberal a use of __forceinline".
(https://blogs.msdn.microsoft.com/vcblog/2018/01/04/visual-studio-2017-throughput-improvements-and-advice/)

We have reported the issue to Microsoft, but in the meantime it would seem wise to define ALWAYS_INLINE as simply "inline" on Windows, which brings the compile time back down to 10 minutes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180328/29ea3be0/attachment.html>