[Webkit-unassigned] [Bug 183964] Add a field to analysis test group indicating whether this test group needs automatical bisection.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 26 11:29:30 PDT 2018


--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 336443
  --> https://bugs.webkit.org/attachment.cgi?id=336443

View in context: https://bugs.webkit.org/attachment.cgi?id=336443&action=review

> Websites/perf.webkit.org/init-database.sql:281
> +    testgroup_auto_bisect boolean NOT NULL DEFAULT FALSE,

I don't think "auto_bisect" is a good name since perf dashboard itself won't automatically bisect this range.
In general, I find that matching database schema naming with a UI facing feature is problematic.
That can lead to a very narrowly scoped database design.

I'm not even certain boolean makes sense here. I could imagine there could be multiple things
change-detection scripts may want to do with this test group like confirming, bisecting, re-testing, etc...
It seems also plausible that change detection scripts need to store some extra states / info per test group.

I really don't think we should be making this database schema change until we have UI & change detection scripts change ready.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180326/9b1d030d/attachment.html>

More information about the webkit-unassigned mailing list