[Webkit-unassigned] [Bug 183448] [GTK][WPE] Add API to convert between DOM and JSCValue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183448

--- Comment #15 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #14)
> (In reply to Carlos Garcia Campos from comment #11)
> > For now, there might be more, but not much more, only the ones that don't
> > inherit from Node and have API not available in JS. They will probably show
> > up when trying to migrate evolution.
> 
> They all inherit from WebKitDOMNode, because WebKitDOMElement itself
> inherits from WebKitDOMNode.

Not at all, WebKitDOMBlob, WebKitDOMCSSRule, WebKitDOMCSSStyleDeclaration, WebKitDOMStyleSheet, WebKitDOMEvent, WebKitDOMRange, and a few other I don't remember now aren't nodes, they inherit from WebKitDOMObject.

> > No, that would require to keep the intermediate classes. I don't think we
> > should expose any HTML class at all.
> 
> OK.
> 
> > What does GTK+ have to do with this? It's very confusing to make this
> > conditional to a GTK+ version when it has nothing to do with GTK+. If we
> > ever bump the ABI version we will simply remove all deprecated code.
> 
> Surely we are going to want to remove this code from the GTK+ 4 API, but we
> are not going to want to drop support for the GTK+ 3 API at the same time.
> So we are going to have to go in and add all these conditionals later anyway.

We will see how to do it, but checking GTK version in glib code shared by GTK and WPE ports is not the right thing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180326/3589b1f5/attachment.html>