[Webkit-unassigned] [Bug 183883] Crash with WebKitConsoleMessageLevel

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 22 10:49:11 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |mcatanzaro at igalia.com

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
I suspect https://trac.webkit.org/changeset/226366/webkit in combination with a Vala bug. Note my changelog entry:

"Since one of the signal arguments is an enum, we now have to run glib-mkenums for the web process API. And that has resulted in this patch also adding GType goo for WebKitConsoleMessageLevel and WebKitConsoleMessageSource that was previously missing. Any applications that for some unlikely reason want to use these enums in properties or signals will be happy."

So webkit_console_message_level_get_type() is brand new in 2.20. Did not exist at all in 2.18.


(In reply to Michael Gratton from comment #0)
> g_enum_get_value (g_type_class_ref (webkit_console_message_level_get_type ()), webkit_console_message_get_level (message));

Vala cannot possibly have generated this code in 2.18, because it would not have compiled. And if it did generate this code, then it has its own conflicting definition for webkit_console_message_level_get_type() with its own generated GType goo, infringing on WebKit's namespace, which would be a Vala bug.

The first thing I would do to check is build Geary twice with the same version of Vala, once with 2.18 and once with 2.20, and diff the generated C code to see what it's doing with respect to webkit_console_message_level_get_type().

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180322/766db443/attachment.html>

More information about the webkit-unassigned mailing list