[Webkit-unassigned] [Bug 181912] Uncaught Exception: TypeError: this._textEditor.toggleUnexecutedCodeHighlights().then is not a function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 18:48:50 PDT 2018


Nikita Vasilyev <nvasilyev at apple.com> changed:

           What    |Removed                     |Added
             Status|NEW                         |ASSIGNED
           Assignee|webkit-unassigned at lists.web |nvasilyev at apple.com
                   |kit.org                     |

--- Comment #2 from Nikita Vasilyev <nvasilyev at apple.com> ---
This is poorly architectured (likely by me 3 years ago).

The [c] icon can only have 3 states:
- gray: disabled, can't be activated.
- black: not activated.
- blue: activated.

The icon updates on setting change. The setting can only have two states:
- enabled.
- disabled.

The setting change is used to update the icon state. Which is wrong, it doesn't even have all 3 states.

The setting should only indicate user preference: enabled (when possible) and disabled.

Instead, the setting is user as a communication channel to set the icon to deactivated state. Currently, the setting gets set to disabled when:
- Enabling pretty-print.
- Editing a script.

Pretty-printing and editing shouldn't change the setting, yet these actions should set the icon to disabled state.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180322/ef38acd2/attachment.html>

More information about the webkit-unassigned mailing list