[Webkit-unassigned] [Bug 183655] JIT callOperation() needs to support operations that return SlowPathReturnType differently on Windows.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 18:22:02 PDT 2018


--- Comment #14 from Ross Kirsling <ross.kirsling at sony.com> ---
Created attachment 336252

  --> https://bugs.webkit.org/attachment.cgi?id=336252&action=review

Test script

(In reply to Ross Kirsling from comment #13)
> I'm also concerned about the deleted non-SPRT cases marked with the comment
> about "interlaced scalar and floating point arguments". For instance, it
> appears that if the third argument is floating-point, then Win64 expects
> argumentFPR3 (and not 0) to be used. Although this is separate from the
> crash that I'm noticing, I assume that this also constitutes lost
> functionality after r229391.

Here is a test script which hits all of the operation types that had Win64-specific codepaths prior to the patch. Having this not crash should hopefully suffice for verification.

Even with my "sloppy fix", the `doubleToString` case is currently failing (complaining of an invalid radix).

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180322/4d030ed3/attachment.html>

More information about the webkit-unassigned mailing list