[Webkit-unassigned] [Bug 183796] Lint web-platform-tests changes with the wpt linter before exporting

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 09:09:18 PDT 2018


--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 336193
  --> https://bugs.webkit.org/attachment.cgi?id=336193

View in context: https://bugs.webkit.org/attachment.cgi?id=336193&action=review

> Tools/Scripts/webkitpy/w3c/test_exporter.py:46
> +sys.path.append(WEBKIT_WPT_DIR)

I wonder whether we have another way of doing this. Jonathan, Dean?
Maybe this explains why webkitpy bot is failing here.

Brendan, you can try to do what the bot is doing to reproduce the issue:
/Volumes/.. /Tools/Scripts/webkit-patch build-and-test --no-clean --no-update --test --non-interactive --build-style=release --group=webkitpy --port=mac

> Tools/Scripts/webkitpy/w3c/test_exporter.py:231
> +        return filter(lambda x: x.startswith(WEBKIT_WPT_DIR), changed_files)

Is it working for all options passed to the exporter, like if a specific commit is specified?
I also wonder whether we should do the lint once we applied the patch to the wpt repo.
That would ensure that we use the latest linter from WPT and not the one from WebKit repo.

> Tools/Scripts/webkitpy/w3c/test_exporter.py:235
> +        repo_root = os.path.abspath(os.path.join(here, os.pardir, os.pardir, os.pardir, os.pardir, 'LayoutTests', 'imported', 'w3c', 'web-platform-tests'))

We usually try to use self._filesystem and not os.path directly.
At some point, we might also want to have check-webkit-style do some lint, so maybe there should be a dedicated class for a WPT lint wrapper.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180321/3634d8da/attachment.html>

More information about the webkit-unassigned mailing list