[Webkit-unassigned] [Bug 183130] [MIPS] Optimize generated JIT code for branches

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183130

--- Comment #10 from Stanislav Ocovaj <stanislav.ocovaj at rt-rk.com> ---
Comment on attachment 335174
  --> https://bugs.webkit.org/attachment.cgi?id=335174
MIPS branches

View in context: https://bugs.webkit.org/attachment.cgi?id=335174&action=review

>> Source/JavaScriptCore/assembler/MIPSAssembler.h:1016
>> +        cacheFlush(insn - 2, codeSize);
> 
> Lol, nice. I think `cacheFlush(instructionStart, codeSize);` is nicer.
> BTW, replaceWithLoad and replaceWithAddressComputation should be fixed at least. Could you review all the other replacing functions too?

replaceWithLoad and replaceWithAddressComputation are OK because they only modify the last instruction. Other functions are also correct. It think repatchInt32 could be modified too, to use cacheFlush(from... instead of cacheFlush(insn... and remove the insn-- statement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180321/a496e7f2/attachment.html>