[Webkit-unassigned] [Bug 183762] 'webkit-patch setup-git-clone' fails when SVN is not installed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 20 09:32:28 PDT 2018


--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Problem is here, in svn.py:

    def in_working_directory(cls, path, executive=None):
        if os.path.isdir(os.path.join(path, '.svn')):
            # This is a fast shortcut for svn info that is usually correct for SVN < 1.7,
            # but doesn't work for SVN >= 1.7.
            return True

        executive = executive or Executive()
        svn_info_args = [cls.executable_name, 'info']
        exit_code = executive.run_command(svn_info_args, cwd=path, return_exit_code=True)
        return (exit_code == 0)

The call to executive.run_command() throws an OSError, and the user gets a nasty traceback. Probably needs to caught and changed to return false, which is what git.py does. Then, at a higher level, provide a sane error message.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180320/20aa5992/attachment-0001.html>

More information about the webkit-unassigned mailing list