[Webkit-unassigned] [Bug 164061] [GTK][WPE] Initial implementation of JavaScriptCore glib bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164061

--- Comment #26 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #23)
> (In reply to Carlos Garcia Campos from comment #22)
> > > > Source/JavaScriptCore/API/glib/JSCClass.h:22
> > > > +#if !defined(__JSC_H_INSIDE__) && !defined(JSC_COMPILATION)
> > > > +#error "Only <jsc/jsc.h> can be included directly."
> > > > +#endif
> > > 
> > > I think we should move this underneath the include guards. It's a
> > > microoptimization, but it annoys me. We can change the existing public APIs
> > > later.
> > 
> > This is what we do everywhere else, I think. This won't be included twice in
> > any case, since it will fail, no?
> 
> It's a very very small microoptimization: if the file starts with the
> include guards, GCC will avoid opening the file repeatedly. We should change
> our existing headers. Yes, there's no behavioral difference.

But that would allow to do something like:

#include <jsc/jsc.h>
#include <jsc/JSCFoo.h>

We never want to allow including headers other than jsc.h even jsc.h has already been included.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180320/c60ce971/attachment.html>