[Webkit-unassigned] [Bug 183696] Use --relative git parameter when applicable to generate WPT patch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183696

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #336041|review?                     |review-
              Flags|                            |

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 336041
  --> https://bugs.webkit.org/attachment.cgi?id=336041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336041&action=review

r- because SVN implementation is inadequate.

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:303
> +            relative_path = relative if relative.endswith('/') else relative + '/'
> +            patch = patch.replace(relative_path, '')

This would replace any string which contains this string. That could be problematic inside Source.
Do a regex match against file names protruded in lines 392-395 in ./Tools/Scripts/svn-create-patch

But a better fix is to add an option to svn-create-patch to specify a relative path as you've done to git.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180319/f0f654db/attachment.html>