[Webkit-unassigned] [Bug 136989] [GTK][WPE] JSC bindings not introspectable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136989

--- Comment #19 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 335930
  --> https://bugs.webkit.org/attachment.cgi?id=335930
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335930&action=review

My attention span compares unfavorably to Donald Trump, so I'm just skimming through this...

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:66
>  #include <JavaScriptCore/JSRetainPtr.h>
> +#include <jsc/JSCContextPrivate.h>
>  #include <WebCore/CertificateInfo.h>

Again, style checker will complain about alphabetization when you set r?

> Source/WebKit/UIProcess/API/gtk/WebKitJavascriptResult.h:52
>  WEBKIT_API JSValueRef
>  webkit_javascript_result_get_value          (WebKitJavascriptResult *js_result);

Shall we deprecate it? I think so, otherwise it will be confusing.

> Source/WebKit/UIProcess/API/gtk/WebKitWebView.h:435
>  WEBKIT_API JSGlobalContextRef
>  webkit_web_view_get_javascript_global_context        (WebKitWebView             *web_view);

Ditto, we should probably deprecate all the JSC C API stuff.

In the unlikely event we ever decide that was a mistake, we can always un-deprecate it. Not like it's going away in the GTK+ 3 API. But this would allow us to not expose the C API at all in the GTK+ 4 API.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180317/81f3e54d/attachment.html>