[Webkit-unassigned] [Bug 183696] Use --relative git parameter when applicable to generate WPT patch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183696

--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 335934
  --> https://bugs.webkit.org/attachment.cgi?id=335934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335934&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:553
> +        test_file_path = test_dir + '/test_file'

I am not sure about slash, since we might at some point move away from Cygwin.
Given that this is done extensively in this file, this might be ok...

> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:302
> +            patch = patch.replace(relative + '/', '')

In that general context, it is not sure that it will do exactly what we want.
This is fine in the context of the exporter.
I would add a comment here stating that the relative parameter should be chosen carefully or a better svn-specific approach be taken.

> Tools/Scripts/webkitpy/w3c/test_exporter.py:211
> +        patch_data = self._host.scm().create_patch(git_commit, [WEBKIT_WPT_DIR], relative=WEBKIT_WPT_DIR)

You might need to update Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py as well

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180316/ef3a640d/attachment.html>