[Webkit-unassigned] [Bug 183197] [GTK] Crash in WTF::equalIgnoringASCIICaseCommon

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 16 10:08:55 PDT 2018


--- Comment #24 from Chris Dumez <cdumez at apple.com> ---
(In reply to Michael Catanzaro from comment #23)
> Looks like allBuiltinSchemes() needs to lock the secureSchemesLock() as well.
> Also, this assert:
>     ASSERT(localURLSchemesLock().isHeld());
> should probably be added to builtinLocalURLSchemes(). Or we could compress
> builtinLocalURLSchemes() and localURLSchemes() together... I don't think we
> need both.
> Lastly, it's rather confusing that only about half of this class is
> threadsafe. This will likely be the source of more bugs in the future if we
> don't change it. My inclination would be to add locking everywhere.

I think we need both maps because it is possible to register new local schemes. However, we do not want SchemeRegistry::allBuiltinSchemes() to start returning those newly registered ones.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180316/db4b3d15/attachment.html>

More information about the webkit-unassigned mailing list